Tagged: code review Toggle Comment Threads | Keyboard Shortcuts

  • Dan 6:39 pm on February 26, 2013 Permalink
    Tags: , code review   

    Can I get a code review of r4126? Want to make sure I’m not breaking something else with the sidebar 🙂

     
    • Koke 2:25 pm on February 27, 2013 Permalink | Reply

      Looks good to me, but I’m not at my best today

  • Koke 2:53 pm on February 18, 2011 Permalink
    Tags: code review,   

    Since I discovered this and started getting jabber notifications on commits, I’ve been trying to review commits as they come, and it’s quite interesting.

    Do you think it’d be a good idea to always get a second pair of eyes to review every commit?

    I haven’t tried it, but Review Board looks like a nice tool to do this

     
    • Danilo 4:21 pm on February 18, 2011 Permalink | Reply

      +1 core review is always a GOOD idea. I haven’t never used a tool like RB, we can try it… or we can just use email 🙂

    • Dan 11:36 pm on February 18, 2011 Permalink | Reply

      Yeah, couldn’t hurt!

c
Compose new post
j
Next post/Next comment
k
Previous post/Previous comment
r
Reply
e
Edit
o
Show/Hide comments
t
Go to top
l
Go to login
h
Show/Hide help
shift + esc
Cancel